novirium
/
airseeder-firmware
1
0
Fork 0
Code Issues 4 Pull Requests Projects Releases Wiki Activity
Labels Milestones
New Issue

Merge the 3 motor control and parameters into single struct and queue #9

Closed
opened 4 years ago by novirium · 1 comments
novirium commented 4 years ago
Owner

Currently in the motor ESP32 firmware, there's a lot of duplication of everthing to keep the 3 motors split out from each other - things like the motor control and parameters structs. The way we've set things up though, all I2C communication in and out of this is doing all three motors at once anyway, and so the ability to reference them individually is never used. It's currently just adding overhead by turning what could be 1 function call or queue interaction into 3.

Currently in the motor ESP32 firmware, there's a lot of duplication of everthing to keep the 3 motors split out from each other - things like the motor control and parameters structs. The way we've set things up though, all I2C communication in and out of this is doing all three motors at once anyway, and so the ability to reference them individually is never used. It's currently just adding overhead by turning what could be 1 function call or queue interaction into 3.
novirium added the [status] Available [type] Enhancement labels 4 years ago
novirium commented 4 years ago
Poster
Owner

Tried this out, and it actually just made this less consistent and more messy. Reverted.

Tried this out, and it actually just made this less consistent and more messy. Reverted.
novirium closed this issue 4 years ago
novirium added [status] Done and removed [status] Available labels 4 years ago
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
Labels
Apply labels
Clear labels
[status] Available
Ready for someone to take up and implement [status] Done
Finished/concluded/completed. Should be closed. [status] In Progress
Being implemented now [status] Review
Currently being discussed [type] Bug
Something isn't working like it says on the box [type] Enhancement
A suggestion for a new change or feature, usually something adding functionality [type] Maintenance
An update to a dependency or a change to keep compatibility with something external that has changed [type] Question
Needs an answer or conclusion to resolve, not a change to the source duplicate
This issue or pull request already exists wontfix
Not be appropriate for the project to fix or implement
No Label [status] Available [status] Done [status] In Progress [status] Review [type] Bug [type] Enhancement [type] Maintenance [type] Question duplicate wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: novirium/airseeder-firmware#9
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '%!s(<nil>)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes