novirium
/
python-preserve
1
0
Fork 0
Code Issues 5 Pull Requests Releases Wiki Activity
Labels Milestones
New Issue

Incorrect type checking #10

Closed
opened 6 years ago by novirium · 0 comments
novirium commented 6 years ago
Owner

Currently types are checked with isinstance() rather than looking at type(). This erroneously includes subclasses of the indicated types - a behaviour that would otherwise restore() back to the parent class.

Currently types are checked with `isinstance()` rather than looking at `type()`. This erroneously includes subclasses of the indicated types - a behaviour that would otherwise `restore()` back to the parent class.
novirium added the [type] Bug [status] Available labels 6 years ago
novirium closed this issue 6 years ago
novirium added [status] Done and removed [status] Available labels 6 years ago
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
Labels
Apply labels
Clear labels
[status] Available
Ready for someone to take up and implement [status] Done
Finished/concluded/completed. Should be closed. [status] In Progress
Being implemented now [status] Review
Currently being discussed [type] Bug
Something isn't working like it says on the box [type] Enhancement
A suggestion for a new change or feature, usually something adding functionality [type] Maintenance
An update to a dependency or a change to keep compatibility with something external that has changed. [type] Question
Needs an answer or conclusion to resolve, not a change to the source duplicate
This issue or pull request already exists wontfix
Not be appropriate for the project to fix or implement
No Label [status] Available [status] Done [status] In Progress [status] Review [type] Bug [type] Enhancement [type] Maintenance [type] Question duplicate wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: novirium/python-preserve#10
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '%!s(<nil>)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes