novirium
/
config-spec
1
0
Fork 0
Code Issues 3 Pull Requests Releases 1 Wiki Activity
Labels Milestones
New Issue

Add default string requirement to not be empty #17

Closed
opened 6 years ago by novirium · 2 comments
novirium commented 6 years ago
Owner

Add kwarg to StringSpec to check if a string is not empty (and probably default it to True)

Add kwarg to StringSpec to check if a string is not empty (and probably default it to True)
novirium added the [status] Available [type] Enhancement labels 6 years ago
novirium commented 5 years ago
Poster
Owner

Though this could be done with the regex argument, I think having the default behaviour reject an empty string is probably a good one (otherwise it'd get confused with being optional). Will implement as an additional allowempty argument that defaults to False.

Though this could be done with the regex argument, I think having the default behaviour reject an empty string is probably a good one (otherwise it'd get confused with being optional). Will implement as an additional `allowempty` argument that defaults to `False`.
novirium commented 5 years ago
Poster
Owner

Added in f27f8f1865

Added in f27f8f1865
novirium closed this issue 5 years ago
novirium added [status] Done and removed [status] Available labels 5 years ago
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
Labels
Apply labels
Clear labels
[status] Available
Ready for someone to take up and implement [status] Done
Finished/concluded/completed. Should be closed. [status] In Progress
Being implemented now [status] Review
Currently being discussed [type] Bug
Something isn't working like it says on the box [type] Enhancement
A suggestion for a new change or feature, usually something adding functionality [type] Maintenance
An update to a dependency or a change to keep compatibility with something external that has changed. [type] Question
Needs an answer or conclusion to resolve, not a change to the source duplicate
This issue or pull request already exists wontfix
Not be appropriate for the project to fix or implement
No Label [status] Available [status] Done [status] In Progress [status] Review [type] Bug [type] Enhancement [type] Maintenance [type] Question duplicate wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: novirium/config-spec#17
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '%!s(<nil>)'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes