Labels Milestones

New Issue

Consider removing the deepcopy step on validate and get_bundle #14

Closed

opened 6 years ago by novirium · 1 comments

novirium commented 6 years ago

Owner

Currently the validate_bundle() and get_config_bundle() methods do a deepcopy of the result before returning it. This was necessary back when the config source was itself mutated and so needed to be copied. Now that the source and validated config are separate copies anyway, having the bundles return as references rather than copies would be convenient to allow systems to mutate their own configuration, while still maintaining the ability to have a "source of truth" by calling validate_bundle().

Currently the `validate_bundle()` and `get_config_bundle()` methods do a deepcopy of the result before returning it. This was necessary back when the config source was itself mutated and so needed to be copied. Now that the source and validated config are separate copies anyway, having the bundles return as references rather than copies would be convenient to allow systems to mutate their own configuration, while still maintaining the ability to have a "source of truth" by calling `validate_bundle()`.

novirium added the [status] Review [type] Enhancement labels 6 years ago

novirium commented 6 years ago

Poster

Owner

Looks like get_config_bundle() was already doing this anyway 😕

Looks like `get_config_bundle()` was already doing this anyway :confused:

novirium referenced this issue from a commit 6 years ago

Remove deepcopy on config bundle return. Closes #14

novirium closed this issue 6 years ago

novirium added [status] Done and removed [status] Review labels 6 years ago

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

v0.3

Labels

Apply labels

Clear labels

[status] Available
Ready for someone to take up and implement [status] Done
Finished/concluded/completed. Should be closed. [status] In Progress
Being implemented now [status] Review
Currently being discussed [type] Bug
Something isn't working like it says on the box [type] Enhancement
A suggestion for a new change or feature, usually something adding functionality [type] Maintenance
An update to a dependency or a change to keep compatibility with something external that has changed. [type] Question
Needs an answer or conclusion to resolve, not a change to the source duplicate
This issue or pull request already exists wontfix
Not be appropriate for the project to fix or implement

No Label [status] Available [status] Done [status] In Progress [status] Review [type] Bug [type] Enhancement [type] Maintenance [type] Question duplicate wontfix

Milestone

Set milestone

Clear milestone

No items

No Milestone

Assignees

Assign users

Clear assignees

No Assignees

1 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: novirium/config-spec#14

Write Preview

Loading…

Cancel

Save

There is no content yet.